Re: [PATCH v1 2/5] ASoC: cs35l56: Add struct to index firmware registers

From: Mark Brown
Date: Mon Apr 07 2025 - 15:32:53 EST


On Mon, Apr 07, 2025 at 04:16:41PM +0100, Stefan Binding wrote:

> Firmware based registers may be different addresses across different
> device ids and revision ids. Create a structure to store and access
> these addresses.

This is fine but note that this is the use case that the regmap_field_
APIs were created for, that also helps deal with things if anyone is
clever and resizes fields or shifts within registers. It's purely a
question of taste if you want to use that.

Attachment: signature.asc
Description: PGP signature