Re: [PATCH v1 1/1] device property: Add a note to the fwnode.h
From: Andy Shevchenko
Date: Mon Apr 07 2025 - 15:12:01 EST
On Mon, Apr 07, 2025 at 08:17:17PM +0200, Rafael J. Wysocki wrote:
> On Mon, Mar 31, 2025 at 6:32 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > Add a note to the fwnode.h that the header should not be used
> > directly in the leaf drivers, they all should use the higher
> > level APIs and the respective headers.
>
> This sounds like a solution to a problem, but the problem statement is missing.
> What's your motivation?
Found a few drivers that are mistakenly include fwnode.h while they meant to
have either of.h or more likely property.h.
...
> > + * Note, this header is not meant to be used by the leaf drivers.
> > + * It provides the low level data types and definitions for the firmware
> > + * and device property providers. The respective API headers should
> > + * guarantee all the required data types and definitions without including
> > + * this header directly.
--
With Best Regards,
Andy Shevchenko