Re: [PATCH 1/2] leds: tlc5928: Driver for the TI 16 Channel spi LED driver

[Christophe JAILLET]

Le 04/04/2025 à 15:54, Corentin GUILLEVIC a écrit :
> Hi,
>
> Thank you for your review! I've fixed everything (new patch is
> coming), but I have issue for some of them: I can't use the suggested
> functions (guard(), for_each_available_child_of_node_scoped() and
> devm_mutex_init()) because the kernel version used on my device is too
> old (v5.15). No way to test with a newer version...
>
> Should I let the "old" functions because of my kernel version?

No strong opinion on my side on this.

The proposed changes were just to have a slightly less verbose code. I 
guess that having a tested code worth much more than using some 
convenience functions to save a few lines of code.

Let see the position of maintainers on it.

CJ