Re: [PATCH v2 0/4] kbuild: resurrect generic header check facility

[Masahiro Yamada]

On Wed, Apr 2, 2025 at 9:47 PM Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
>
> Another go at hiding the turds.
>
> In v1 [1] I hid the build artifacts under .hdrtest subdirectories, one in each
> $(obj) directory, but the feedback from Linus [2] was to have one top level
> directory for this.
>
> This is not possible without turning the whole thing back into a generic header
> check facility. Personally, I think this is a good thing. Just look at patches
> 2-4, it's great.
>
> The main reason we've been doing this in the subsystem/driver level at all is
> the opposition from the kbuild maintainer. We'd very much like for Masahiro to
> support us in our efforts, but without that support, we're limited to hacking in
> the subsystem/driver Makefiles.
>
> BR,
> Jani.
>
>
> [1] https://lore.kernel.org/r/20250401121830.21696-1-jani.nikula@xxxxxxxxx
>
> [2] https://lore.kernel.org/r/CAHk-=wiP0ea7xq2P3ryYs6xGWoqTw1E4jha67ZbJkaFrjqUdkQ@xxxxxxxxxxxxxx
>
>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Cc: Masahiro Yamada <masahiroy@xxxxxxxxxx>


NACK.

This does not solve any real issue, except making Linus happy
- Sure, he is happy as long as he no longer has to see the turds.

This patch merely hides the turds by moving all the
header-test build artifacts under the .header-check/
and introducing CONFIG_HEADER_CHECK_DISABLE.
Yes, Linus advised us to hide all the turds because he cares
about the TAB-completion.

But to me, from the Kbuild perspective, this is not a solution at all.
What is worse, Jani is pushing his workaround into the common
Kbuild Makefiles, which I maintain, and he is even make this
broken feature widely accessible.

I agree with Jason.
His idea sounds better, although I do not have enough time
for investigating it further or implementing it now.


At least, this patchset is not something we should rush into.



> Cc: David Airlie <airlied@xxxxxxxxx>
> Cc: Simona Vetter <simona.vetter@xxxxxxxx>
> Cc: linux-kbuild@xxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: intel-xe@xxxxxxxxxxxxxxxxxxxxx
> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
>
>
> Jani Nikula (4):
>   kbuild: add generic header check facility
>   drm: switch to generic header check facility
>   drm/i915: switch to generic header check facility
>   drm/xe: switch to generic header check facility
>
>  drivers/gpu/drm/Kconfig           |  2 +-
>  drivers/gpu/drm/Makefile          | 15 +--------------
>  drivers/gpu/drm/i915/Makefile     | 14 ++------------
>  drivers/gpu/drm/xe/Makefile       | 10 ++--------
>  drivers/gpu/drm/xe/xe_pcode_api.h |  4 ++++
>  include/drm/Makefile              | 15 +--------------
>  init/Kconfig                      | 25 +++++++++++++++++++++++++
>  scripts/Makefile.build            | 13 +++++++++++++
>  scripts/Makefile.lib              |  7 +++++++
>  9 files changed, 56 insertions(+), 49 deletions(-)
>
> --
> 2.39.5
>


-- 
Best Regards
Masahiro Yamada