Re: [PATCH] rust: clean Rust 1.86.0 new `clippy::needless_continue` cases

[Tamir Duberstein]

On Wed, Apr 2, 2025 at 4:29 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Wed, Apr 2, 2025 at 6:41 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
> >
> > The counterfactual is hard to prove - you don't know what true
> > positives the lint would catch. In my opinion disabling lints is
> > risking throwing the baby out with the bathwater.
>
> It is true that it is not easy to know what we will exactly lose right
> now (apart from what it claims in the docs and its examples), but one
> can easily test enabling it in a couple cycles and we would have some
> data from kernel code.
>
> To be clear, disabling now does not mean forever -- we can reevaluate
> with that data and possible improvements to the lint that happened
> meanwhile (sometimes they get improved or split due to feedback).

My experience in industrial settings is that this happens very rarely.

> By the way, the lint is in "pedantic" in Clippy and disabled by
> default -- so we are "only" disabling w.r.t. what we do nowadays.

> In any case, my main concern is cost: we already require a lot from
> Rust kernel developers, typically more than in C, and while one goal
> of the project is trying to see how far we can go on being strict
> about things like lints, I worry we may overdo it at times.

👍

I don't have any new information to inject into this debate. It's a
judgement call.