Re: [PATCH] bcachefs: use library APIs for ChaCha20 and Poly1305

[Kent Overstreet]

On Tue, Apr 01, 2025 at 09:33:33PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> Just use the ChaCha20 and Poly1305 libraries instead of the clunky
> crypto API.  This is much simpler.  It is also slightly faster, since
> the libraries provide more direct access to the same
> architecture-optimized ChaCha20 and Poly1305 code.
> 
> I've tested that existing encrypted bcachefs filesystems can be continue
> to be accessed with this patch applied.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Fantastic!

Applied, and this should go into 6.15 - this should get the strange bugs
in the poly1305 path that I wasn't able to reproduce off the dashboard
(and if they're still there, they'll be much easier to debug.)