Re: [PATCH net] bnxt_en: bring back rtnl lock in bnxt_shutdown
From: Jakub Kicinski
Date: Mon Mar 31 2025 - 13:16:45 EST
On Mon, 31 Mar 2025 09:53:16 -0700 Breno Leitao wrote:
> > But also in general, it would be nice to keep existing
> > rtnl+instance_lock scheme for now (except were we want to explicitly opt
> > out, as in queue apis); we can follow up later to un-rtnl the rest.
>
> I am just wondering if the code as-is is already safe from a locking
> perspecting, and just the warning (ASSERT_RTNL) is wrong.
I suspect the notifiers for DOWN may expect to be called with rtnl held.