Re: [PATCH v2] dt-bindings: gpio: pca95xx: add Toradex ecgpiol16

[Conor Dooley]

On Mon, Mar 31, 2025 at 09:26:44AM +0200, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>
> 
> The Toradex ecgpiol16 is a 16-bit I2C I/O expander implemented using a
> small MCU.
> Its register interface and behavior are compatible with the PCAL6416.
> 
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> ---
> v2: compatible changed from embedded-controller-io16 to ecgpiol16
> v1: https://lore.kernel.org/all/20250328122917.43273-1-francesco@xxxxxxxxxx/
> ---
>  Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> index 7b1eb08fa055..4d3f52f8d1b8 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> @@ -16,6 +16,9 @@ description: |+
>  properties:
>    compatible:
>      oneOf:
> +      - items:
> +          - const: toradex,ecgpiol16
> +          - const: nxp,pcal6416
>        - items:

>            - const: diodes,pi4ioe5v6534q

You could have made this into an enum, and added your new compatible
there. If there's a respin, can you do that please?
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

>            - const: nxp,pcal6534
> @@ -132,6 +135,7 @@ allOf:
>                - maxim,max7325
>                - maxim,max7326
>                - maxim,max7327
> +              - toradex,ecgpiol16
>      then:
>        properties:
>          reset-gpios: false
> -- 
> 2.39.5
>

Attachment: signature.asc
Description: PGP signature