Re: [PATCH] clk: ti: Simplify ti_find_clock_provider()

From: Andreas Kemnade
Date: Mon Mar 31 2025 - 05:53:49 EST


Am Wed, 12 Mar 2025 11:33:30 -0500
schrieb "Rob Herring (Arm)" <robh@xxxxxxxxxx>:

> Remove using for_each_of_allnodes_from() which is not safe to use
> without holding the DT spinlock. In reality that probably doesn't
> matter here. This is the only user in the whole tree, so it can be
> made private once removed here. The "from" argument is always NULL, so
> it can be dropped as well.
>
> There's a slight change in behavior in matching the "clock-output-names"
> value as the prior code would match if the node name matched the
> beginning of the value and the comparision was case insensitive. Now
> it must be an exact match.
>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---
> Compiled only. I'm not sure if the the change in behavior is going to
> matter.
>
did some testing. Nothing odd seen at the platforms I tested but I feel
a bit uncomfortable with
https://lore.kernel.org/linux-clk/20240925100603.4cba9176@akair/
in combination with this.

Regards,
Andreas