Re: [PATCH v8 08/13] misc: rp1: RaspberryPi RP1 misc driver

[Krzysztof Wilczynski]

Hello,

Thank you for sending new version.  Appreciated.

> +	case IRQ_TYPE_LEVEL_HIGH:
> +		dev_dbg(&rp1->pdev->dev, "MSIX IACK EN for irq %u\n", hwirq);
> +		msix_cfg_set(rp1, hwirq, MSIX_CFG_IACK_EN);
> +		rp1->level_triggered_irq[hwirq] = true;

[...]
> +		if (!irq) {
> +			dev_err(&pdev->dev, "Failed to create irq mapping\n");
> +			err = -EINVAL;
> +			goto err_unregister_interrupts;
> +		}

A small nitpick: "IRQ" in both of the above.  Not a blocker, though, so
feel free to ignore this feedback.

	Krzysztof