Re: [PATCH v3 06/18] nvmet-fcloop: sync targetport removal

From: Christoph Hellwig
Date: Fri Mar 21 2025 - 02:08:50 EST


On Tue, Mar 18, 2025 at 11:40:00AM +0100, Daniel Wagner wrote:
> The nvmet-fc uses references on the targetport to ensure no UAFs
> happens. The consequence is that when the targetport is unregistered,
> not all resources are freed immediately. Ensure that all activities from
> the unregister call have been submitted (deassocication) before
> continuing with the shutdown sequence.

This needs to explain why that is needed. In general a completion
waiting for references to go away is a bit of an anti-patter, so
it should come with a good excuse.