Re: [PATCH v15 3/3] PCI: amd-mdb: Add AMD MDB Root Port driver

[Geert Uytterhoeven]

Hi Thippeswamy,

On Fri, 28 Feb 2025 at 10:35, Thippeswamy Havalige
<thippeswamy.havalige@xxxxxxx> wrote:
> Add support for AMD MDB (Multimedia DMA Bridge) IP core as Root Port.
>
> The Versal2 devices include MDB Module. The integrated block for MDB along
> with the integrated bridge can function as PCIe Root Port controller at
> Gen5 32-GT/s operation per lane.
>
> Bridge supports error and INTx interrupts and are handled using platform
> specific interrupt line in Versal2.
>
> Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@xxxxxxx>

Thanks for your patch, which is now commit e229f853f5b277a5
("PCI: amd-mdb: Add AMD MDB Root Port driver") in pci/next.

> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -27,6 +27,17 @@ config PCIE_AL
>           required only for DT-based platforms. ACPI platforms with the
>           Annapurna Labs PCIe controller don't need to enable this.
>
> +config PCIE_AMD_MDB
> +       bool "AMD MDB Versal2 PCIe Host controller"
> +       depends on OF || COMPILE_TEST

AFAIK, AMD Versal2 is an ARM64 SoC, so this should depend on (at least)
ARM64 || COMPILE_TEST, too.  If there's ever gonna be an ARCH_VERSAL
symbol, it could be used as a dependency instead.

> +       depends on PCI && PCI_MSI
> +       select PCIE_DW_HOST
> +       help
> +         Say Y here if you want to enable PCIe controller support on AMD
> +         Versal2 SoCs. The AMD MDB Versal2 PCIe controller is based on
> +         DesignWare IP and therefore the driver re-uses the DesignWare core
> +         functions to implement the driver.
> +

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds