Re: [PATCH] wifi: mac80211: Add __nonstring annotations for unterminated strings

From: Kees Cook
Date: Tue Mar 11 2025 - 18:36:57 EST


On Tue, Mar 11, 2025 at 10:25:10AM +0100, Johannes Berg wrote:
> On Mon, 2025-03-10 at 15:23 -0700, Kees Cook wrote:
> >
> > drivers/net/wireless/virtual/virt_wifi.c | 2 +-
> > drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 2 +-
> >
>
> That's not mac80211?

Hrm, you're right. The automation I use for splitting up "treewide"
changes per subsystem tries to guess at a reasonable subject give a set
of files, based on historical git subject prefixes. And these two files
ended up grouped together because no more specific subsystem claimed
them.

It seems I should probably split this into two, as:

wifi: zd1211rw:
wifi: virt_wifi:

> Also, I have no idea how you came up with the CC list but it seems
> excessive. :)

It's based on my permutation of arguments to get_maintainers.pl that
seems to work best for splitting my "treewide" changes per subsystem:

ccs = subprocess.run(["./scripts/get_maintainer.pl", "--email",
"--git-min-percent", "15",
"--git-since", '3-years-ago',
"--no-rolestats", patch.name],

-Kees

--
Kees Cook