Re: [PATCH v6 42/42] x86/resctrl: Add python script to move resctrl code to /fs/resctrl

[James Morse]

Hi Fenghua,

On 25/02/2025 05:02, Fenghua Yu wrote:
> On 2/7/25 10:18, James Morse wrote:
>> To support more than one architecture resctrl needs to move from arch/x86
>> to live under fs. Moving all the code breaks any series on the mailing
>> list, so needs scheduling carefully.
>>
>> Maintaining the patch that moves all this code has proved labour intensive.
>> It's also near-impossible to review that no inadvertent changes have
>> crept in.
>>
>> To solve these problems, temporarily add a hacky python program that
>> lists all the functions that should move, and those that should stay.
>>
>> No attempt to parse C code is made, this thing tries to name 'blocks'
>> based on hueristics about the kernel coding style. It's fragile, but
>> good enough for its single use here.
>>
>> This only exists to show I have nothing up my sleeve.
>> I don't suggested this gets merged.
>>
>> The patch this script generaets has the following corner cases:
>> * The original files are regenerated, which will add newlines that are
>>    not present in the original file.
>> * An trace-point header file the only contains boiler-plate is created
>>    in the arch and filesystem code. The parser doesn't know how to remove
>>    the includes for these - but its easy to 'keep' the file contents on
>>    the correct side. A follow-up patch will remove these files and their
>>    includes.
> 
> Due to no trace event defined in the _trace.h files, compilation errors are reported when
> building kernel by W=1.
> 
> This patch seems the "follow-up" patch mentioned here? After this patch is applied, no
> more errors reported when W=1.

Yup, the follow up is here:
https://web.git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/commit/?h=mpam/snapshot/v6.14-rc1&id=3d0430324a0c7e7ad765140f9e78a9a312a13573

I thought this was harmless, but evidently kbuild doesn't like it.
I'll include all these in v7 - I suggest they get squashed into the generated patch once
they're reviewed.


Thanks,

James