Re: [PATCH v2 6/7] iommufd: Implement sw_msi support natively

From: Jason Gunthorpe
Date: Thu Feb 27 2025 - 14:33:42 EST


On Wed, Feb 19, 2025 at 05:31:41PM -0800, Nicolin Chen wrote:

> + cur = kzalloc(sizeof(*cur), GFP_KERNEL);
> + if (!cur)
> + cur = ERR_PTR(-ENOMEM);

^^^^^^^^^^^^^^^^

> + cur->sw_msi_start = sw_msi_start;
> + cur->msi_addr = msi_addr;
> + cur->pgoff = max_pgoff;
> + cur->id = ictx->sw_msi_id++;
> + list_add_tail(&cur->sw_msi_item, &ictx->sw_msi_list);
> + return cur;
> +}

Dan pointed out this should have been
return ERR_PTR(-ENOMEM);

I fixed it up

Thanks,
Jason