Re: Question about config UPROBES and UPROBE_EVENTS

[Tiezhu Yang]

On 09/30/2024 07:15 AM, Masami Hiramatsu (Google) wrote:
> On Wed, 11 Sep 2024 14:40:56 +0800
> Tiezhu Yang <yangtiezhu@xxxxxxxxxxx> wrote:
>
> > Hi Masami,
> >
> > I am a little confused about config UPROBES and UPROBE_EVENTS.
> > Uprobes is the user-space counterpart to kprobes, I want to do
> > some small changes:
> >
> > (1) since config KPROBES can be selectable, just make config UPROBES
> >      selectable too.
> >
> > (2) since config KPROBE_EVENTS depends on KPROBES rather than select
> >      KPROBES, just make config UPROBE_EVENTS depends on UPROBES rather
> >      than select UPROBES.
> >
> > Could you please let me know are you OK with the following changes?
> > If yes, I will send formal patches later.
>
> Hm, I don't completely reject this idea,

Thanks for your reply. I have almost dropped this idea due to my
thoughtless after receiving the reply of Steven Rostedt [1].

> but I'm not sure about the benefits
> to users and keeping backward compatibility.

Yes, I think so too.

> Especially, the latter one
> may hide uprobe_events by default.

Yes.

> As you can see, the CONFIG_KPROBES is
> enabled by default, thus it does not hide the CONFIG_KPROBE_EVENTS.But

Maybe I missed something, AFAICT, the CONFIG_KPROBES is disabled by
default, it needs to enable manually by the users, and also we can
not see the CONFIG_KPROBE_EVENTS menu if CONFIG_KPROBES is not set
because CONFIG_KPROBE_EVENTS depends on CONFIG_KPROBES.

> the CONFIG_UPROBES is disabled by default and make CONFIG_UPROBE_EVENTS
> depending on it, the uprobe_events menu is hidden. I don't like this.

This is somehow like the current status of CONFIG_KPROBES and
CONFIG_KPROBE_EVENTS.


[1] https://lore.kernel.org/all/20240911094317.4a28fc3b@xxxxxxxxxxxxxxxxxx/

Thanks,
Tiezhu