Re: [PATCH V7] squashfs: Add symlink size check in squash_read_inode

[Phillip Lougher]

On 04/08/2024 22:20, Al Viro wrote:
> On Sun, Aug 04, 2024 at 10:16:05PM +0100, Phillip Lougher wrote:
>
> > NACK. I see no reason to introduce an intermediate variable here.
> >
> > Please do what Al Viro suggested.
>
> Alternatively, just check ->i_size after assignment.  loff_t is
> always a 64bit signed; le32_to_cpu() returns 32bit unsigned.
> Conversion from u32 to s64 is always going to yield a non-negative
> result; comparison with PAGE_SIZE is all you need there.

I'm happy with that as well.

Thanks

Phillip