Re: [PATCH] Convert the Broadcom OTP memory controller to newer DT schema. Created DT schema based on the .txt file which had `compatible`, `reg` `brcm,ocotp-size` as the required properties.

From: Krzysztof Kozlowski
Date: Wed May 15 2024 - 10:27:05 EST

Next message: Waiman Long: "Re: cgroup io.stat propagation regression"
Previous message: Arnd Bergmann: "Re: [PATCH] LoongArch: Define __ARCH_WANT_NEW_STAT in unistd.h"
In reply to: Pratik Farkase: "[PATCH] Convert the Broadcom OTP memory controller to newer DT schema. Created DT schema based on the .txt file which had `compatible`, `reg` `brcm,ocotp-size` as the required properties."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 15/05/2024 16:07, Pratik Farkase wrote:
> Signed-off-by: Pratik Farkase <pratik.farkase@xxxxxxxxxxxxx>

That's not a proper commit... Read introduction to Git how to create
commits.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Code itself looked good.

Best regards,
Krzysztof

Next message: Waiman Long: "Re: cgroup io.stat propagation regression"
Previous message: Arnd Bergmann: "Re: [PATCH] LoongArch: Define __ARCH_WANT_NEW_STAT in unistd.h"
In reply to: Pratik Farkase: "[PATCH] Convert the Broadcom OTP memory controller to newer DT schema. Created DT schema based on the .txt file which had `compatible`, `reg` `brcm,ocotp-size` as the required properties."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]