Re: [PATCH v2] ASoC: dt-bindings: ak4104: convert to dt schema

[Krzysztof Kozlowski]

On 14/05/2024 09:11, Xiaxi Shen wrote:
> Convert ak4104 binding to DT schema
> 
> Signed-off-by: Xiaxi Shen <shenxiaxi26@xxxxxxxxx>
> ---
> Changes in v2:
>  - Remove subsystem maintainers
>  - Wrap lines at <80
> 
> Signed-off-by: Xiaxi Shen <shenxiaxi26@xxxxxxxxx>

Only one SoB.

..

> +title: AK4104 S/PDIF transmitter
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +maintainers:
> +  - Daniel Mack <github@xxxxxxxxxx>
> +  - Xiaxi Shen <shenxiaxi26@xxxxxxxxx>
> +
> +properties:
> +  compatible:
> +    const: asahi-kasei,ak4104
> +
> +  reg:
> +    description: Chip select number on the SPI bus 
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: A regulator node providing between 2.7V and 3.6V.
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: Optional GPIO spec for the reset pin, deasserted 
> +                  before communication starts.
> +    
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +additionalProperties: false

unevaluatedProperties instead, so the dai-cells will be allowed.

> +
> +examples:
> +  - |
> +   i2c {

Indentation looks odd here. It should start with | above. See other files.

Best regards,
Krzysztof