Re: [PATCH v2, net-next, 2/2] net: stmmac: PCI driver for BCM8958X SoC

From: Russell King (Oracle)
Date: Sat May 11 2024 - 13:13:08 EST


On Sat, May 11, 2024 at 06:16:52PM +0200, Andrew Lunn wrote:
> > + /* This device interface is directly attached to the switch chip on
> > + * the SoC. Since no MDIO is present, register fixed_phy.
> > + */
> > + brcm_priv->phy_dev =
> > + fixed_phy_register(PHY_POLL,
> > + &dwxgmac_brcm_fixed_phy_status, NULL);
> > + if (IS_ERR(brcm_priv->phy_dev)) {
> > + dev_err(&pdev->dev, "%s\tNo PHY/fixed_PHY found\n", __func__);
> > + return -ENODEV;
> > + }
> > + phy_attached_info(brcm_priv->phy_dev);
>
> What switch is it? Will there be patches to extend SF2?

.. and why is this legacy fixed_phy even necessary when stmmac uses
phylink which supports fixed links, including with custom fixed status?

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!