RE: RE: [PATCH v5] platform/x86: dell-laptop: Implement platform_profile
From: Lyndon Sanche
Date: Sat May 11 2024 - 12:02:44 EST
On May 11, 2024 9:05:15 a.m. MDT, "Shen, Yijun" <Yijun.Shen@xxxxxxxx> wrote:
>
>Internal Use - Confidential
>> -----Original Message-----
>> From: Mario Limonciello <mario.limonciello@xxxxxxx>
>> Sent: Wednesday, May 8, 2024 11:53 PM
>> To: Shen, Yijun <Yijun_Shen@xxxxxxxx>; Lyndon Sanche
>> <lsanche@xxxxxxxxxx>
>> Cc: pali@xxxxxxxxxx; W_Armin@xxxxxx;
>> srinivas.pandruvada@xxxxxxxxxxxxxxx; ilpo.jarvinen@xxxxxxxxxxxxxxx;
>> lkp@xxxxxxxxx; Hans de Goede <hdegoede@xxxxxxxxxx>; Matthew Garrett
>> <mjg59@xxxxxxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>; Heiner Kallweit
>> <hkallweit1@xxxxxxxxx>; Vegard Nossum <vegard.nossum@xxxxxxxxxx>;
>> platform-driver-x86@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Dell Client
>> Kernel <Dell.Client.Kernel@xxxxxxxx>
>> Subject: Re: RE: [PATCH v5] platform/x86: dell-laptop: Implement
>> platform_profile
>>
>>
>> [EXTERNAL EMAIL]
>>
>> On 5/8/2024 09:24, Shen, Yijun wrote:
>> > Hi Lyndon,
>> >
>> > Thanks for working on this patch.
>> >
>> >>
>> > Dell side has an initial testing with this patch on some laptops, it looks
>> good. While changing the platform profile:
>> > 1. The corresponding USTT option in BIOS will be changed.
>> > 2. thermald will not be impacted. The related PSVT and ITMT will be loaded.
>> > Some Dell DTs does not have the USTT, Dell'll have a check if nothing is
>> broken.
>>
>> Hi Alex!
>>
>> Have you had a check both on both your AMD laptops and workstations too,
>> or just the Intel ones? I think it would be good to make sure it's getting the
>> correct experience in both cases.
>>
>Hi Mario,
>
> I've a check for this, for both laptop and workstation, the dell_laptop module will not be loaded. So, AMD platform will not be impacted by this patch series.
>Follow is one example output with workstation.
> #lsmod | grep dell
> dell_wmi 28672 0
> dell_smbios 32768 1 dell_wmi
> dcdbas 20480 1 dell_smbios
> dell_wmi_descriptor 20480 2 dell_wmi,dell_smbios
> sparse_keymap 12288 1 dell_wmi
> ledtrig_audio 12288 3 snd_ctl_led,snd_hda_codec_generic,dell_wmi
> video 73728 2 dell_wmi,nvidia_modeset
> wmi 40960 5 video,dell_wmi,wmi_bmof,dell_smbios,dell_wmi_descriptor
>
Should AMD platforms be affected? Do they support the USTT modes as well?