Re: [PATCH net-next 01/14] net: qede: use extack in qede_flow_parse_ports()

[Asbjørn Sloth Tønnesen]

Hi Przemek,

Thank you for the review!

On 5/8/24 10:07 AM, Przemek Kitszel wrote:
> On 5/7/24 12:44, Asbjørn Sloth Tønnesen wrote:
> > Convert qede_flow_parse_ports to use extack,
> > and drop the edev argument.
> >
> > Convert DP_NOTICE call to use NL_SET_ERR_MSG_MOD instead.
> >
> > In calls to qede_flow_parse_ports(), use NULL as extack
> > for now, until a subsequent patch makes extack available.
> >
> > Only compile tested.
> >
> > Signed-off-by: Asbjørn Sloth Tønnesen <ast@xxxxxxxxxxx>
> > ---
> >   drivers/net/ethernet/qlogic/qede/qede_filter.c | 9 +++++----
> >   1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c
> > index ded48523c383..3995baa2daa6 100644
> > --- a/drivers/net/ethernet/qlogic/qede/qede_filter.c
> > +++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c
> > @@ -1700,7 +1700,7 @@ static int qede_parse_actions(struct qede_dev *edev,
> >   }
> >   static int
> > -qede_flow_parse_ports(struct qede_dev *edev, struct flow_rule *rule,
> > +qede_flow_parse_ports(struct netlink_ext_ack *extack, struct flow_rule *rule,
> >                 struct qede_arfs_tuple *t)
>
> there are ~40 cases in drivers/net/ethernet that have an extack param as
> not the last one, and over 1250 that have an extack as the last param.
> My grepping was very naive, and counted both forward declarations and
> implementations, but it's clear what is the preference.
>
> Could you please convert the series to be that way?

Sure, will do that in v2.

--
Best regards
Asbjørn Sloth Tønnesen
Network Engineer
Fiberby - AS42541