Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'

[Dr. David Alan Gilbert]

* Bjorn Helgaas (helgaas@xxxxxxxxxx) wrote:
> On Mon, May 06, 2024 at 02:43:20PM +0000, Dr. David Alan Gilbert wrote:
> > * Ilpo Järvinen (ilpo.jarvinen@xxxxxxxxxxxxxxx) wrote:
> > > On Mon, 6 May 2024, linux@xxxxxxxxxxx wrote:
> > > 
> > > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > > > 
> > > > This doesn't look like it was ever used.
> > > 
> > > Don't start with "This" but spell what you're talking about out so it 
> > > can be read and understood without shortlog in Subject (or looking into 
> > > the code change).
> > 
> > I'm of course happy to rework that if it helps you, although
> > I thought the subject line was sufficient.
> 
> It's a minor point, to be sure.  The way I think about this is "an
> essay title is not part of the essay itself," so the essay (commit
> log) should make sense all by itself.

OK, modified v2 sent.

Dave

> Bjorn
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/