Re: [PATCH v1 0/8] Address/leak sanitizer clean ups
From: Arnaldo Carvalho de Melo
Date: Tue May 07 2024 - 16:51:48 EST
On Tue, May 07, 2024 at 11:35:37AM -0700, Ian Rogers wrote:
> Remove unnecessary reference counts for structs with no gets. Add
> reference count checking to comm_str and mem_info. Fix memory leaks
> and errors detected on "perf mem report" by address sanitizer and leak
> sanitizer.
Applied locally, doing build tests. Will soon go to tmp.perf-tools-next.
- Arnaldo
> Ian Rogers (8):
> perf ui browser: Don't save pointer to stack memory
> perf annotate: Fix memory leak in annotated_source
> perf block-info: Remove unused refcount
> perf cpumap: Remove refcnt from cpu_aggr_map
> perf comm: Add reference count checking to comm_str
> perf mem-info: Move mem-info out of mem-events and symbol
> perf mem-info: Add reference count checking
> perf hist: Avoid hist_entry_iter mem_info memory leak
>
> tools/perf/builtin-c2c.c | 13 +-
> tools/perf/builtin-report.c | 3 +-
> tools/perf/builtin-script.c | 12 +-
> tools/perf/builtin-stat.c | 16 +-
> tools/perf/tests/mem.c | 11 +-
> tools/perf/ui/browser.c | 4 +-
> tools/perf/ui/browser.h | 2 +-
> tools/perf/util/Build | 1 +
> tools/perf/util/annotate.c | 6 +
> tools/perf/util/block-info.c | 22 +-
> tools/perf/util/block-info.h | 15 +-
> tools/perf/util/comm.c | 196 +++++++++++-------
> tools/perf/util/cpumap.c | 2 -
> tools/perf/util/cpumap.h | 2 -
> tools/perf/util/hist.c | 62 +++---
> tools/perf/util/hist.h | 8 +-
> tools/perf/util/machine.c | 7 +-
> tools/perf/util/mem-events.c | 36 ++--
> tools/perf/util/mem-events.h | 29 +--
> tools/perf/util/mem-info.c | 35 ++++
> tools/perf/util/mem-info.h | 54 +++++
> .../scripting-engines/trace-event-python.c | 12 +-
> tools/perf/util/sort.c | 69 +++---
> tools/perf/util/symbol.c | 26 +--
> tools/perf/util/symbol.h | 12 --
> 25 files changed, 370 insertions(+), 285 deletions(-)
> create mode 100644 tools/perf/util/mem-info.c
> create mode 100644 tools/perf/util/mem-info.h
>
> --
> 2.45.0.rc1.225.g2a3ae87e7f-goog