[RFC PATCH 3/3] ACPI: extlog: Make print_extlog_rcd() log unconditionally

From: Fabio M. De Francesco
Date: Tue May 07 2024 - 15:08:37 EST


Make extlog_print_rcd() log unconditionally to report errors even if
userspace is not consuming trace events. Remove ras_userspace_consumers()
because it is not anymore used.

This change makes extlog_print() (ELOG) to act consistently to ghes_proc()
(GHES).

Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Signed-off-by: Fabio M. De Francesco <fabio.m.de.francesco@xxxxxxxxxxxxxxx>
---
drivers/acpi/acpi_extlog.c | 6 +-----
drivers/ras/debugfs.c | 6 ------
include/linux/ras.h | 2 --
3 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c
index c167e391ba43..7bb1204080ef 100644
--- a/drivers/acpi/acpi_extlog.c
+++ b/drivers/acpi/acpi_extlog.c
@@ -185,10 +185,7 @@ static int extlog_print(struct notifier_block *nb, unsigned long val,

tmp = (struct acpi_hest_generic_status *)elog_buf;

- if (!ras_userspace_consumers()) {
- print_extlog_rcd(NULL, tmp, cpu);
- goto out;
- }
+ print_extlog_rcd(NULL, tmp, cpu);

/* log event via trace */
err_seq++;
@@ -222,7 +219,6 @@ static int extlog_print(struct notifier_block *nb, unsigned long val,
}
}

-out:
mce->kflags |= MCE_HANDLED_EXTLOG;
return NOTIFY_OK;
}
diff --git a/drivers/ras/debugfs.c b/drivers/ras/debugfs.c
index 42afd3de68b2..6633844acdd6 100644
--- a/drivers/ras/debugfs.c
+++ b/drivers/ras/debugfs.c
@@ -13,12 +13,6 @@ struct dentry *ras_get_debugfs_root(void)
}
EXPORT_SYMBOL_GPL(ras_get_debugfs_root);

-int ras_userspace_consumers(void)
-{
- return atomic_read(&trace_count);
-}
-EXPORT_SYMBOL_GPL(ras_userspace_consumers);
-
static int trace_show(struct seq_file *m, void *v)
{
return 0;
diff --git a/include/linux/ras.h b/include/linux/ras.h
index a64182bc72ad..98840f16b697 100644
--- a/include/linux/ras.h
+++ b/include/linux/ras.h
@@ -7,11 +7,9 @@
#include <linux/cper.h>

#ifdef CONFIG_DEBUG_FS
-int ras_userspace_consumers(void);
void ras_debugfs_init(void);
int ras_add_daemon_trace(void);
#else
-static inline int ras_userspace_consumers(void) { return 0; }
static inline void ras_debugfs_init(void) { }
static inline int ras_add_daemon_trace(void) { return 0; }
#endif
--
2.45.0