Re: [PATCH 1/6] dt-bindings: input: touchscreen: himax,hx83112b: add HX83100A

[Rob Herring]

On Sat, May 04, 2024 at 02:34:08PM +0200, Krzysztof Kozlowski wrote:
> On 04/05/2024 04:04, Felix Kaechele wrote:
> > This adds a compatible string for the Himax HX83100A touch controller
> 
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> 
> > including the AVDD and VDD supply nodes used by this chip family.
> > 
> > Signed-off-by: Felix Kaechele <felix@xxxxxxxxxxx>
> > ---
> >  .../bindings/input/touchscreen/himax,hx83112b.yaml       | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
> > index f42b23d532eb..5809afedb9a2 100644
> > --- a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
> > @@ -15,6 +15,7 @@ allOf:
> >  properties:
> >    compatible:
> >      enum:
> > +      - himax,hx83100a
> >        - himax,hx83112b
> >  
> >    reg:
> > @@ -26,6 +27,12 @@ properties:
> >    reset-gpios:
> >      maxItems: 1
> >  
> > +  avdd-supply:
> > +    description: Analog power supply regulator
> > +
> > +  vdd-supply:
> > +    description: Digital power supply regulator
> 
> These should not be allowed for other variant, so either you need
> allOf:if:then disallowing them (: false) or just create another binding
> file.

Or the commit message needs some explanation that the supplies also 
apply to the 83112b as the existing binding has no supplies. 

Rob