Re: [PATCH 2/4] ASoC: qcom: q6dsp: Implement proper channel mapping in Audioreach

[Krzysztof Kozlowski]

On 07/05/2024 15:25, Srinivas Kandagatla wrote:
> 
> 
> On 07/05/2024 11:27, Krzysztof Kozlowski wrote:
>> Instead of relying on default channel mapping in all Audioreach
>> platforms, implement set_channel_map() callback to allow sound cards
>> customize the mapping depending on needs.
>>
>> The channel mapping is set on frontend DAIs coming from the topology,
>> not DTS, thus need to add DAI ops in topology dai_load() callback.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>>   sound/soc/qcom/qdsp6/audioreach.c |  2 +-
>>   sound/soc/qcom/qdsp6/audioreach.h |  1 +
>>   sound/soc/qcom/qdsp6/q6apm.c      | 28 +++++++++++++++++++++++++++-
>>   sound/soc/qcom/qdsp6/q6apm.h      |  8 ++++++++
>>   sound/soc/qcom/qdsp6/topology.c   | 12 ++++++++++++
>>   5 files changed, 49 insertions(+), 2 deletions(-)
> Please use the existing q6dma_set_channel_map() and set the channel map 
> for the backend dai from machine driver, this should work.
> 
> setting channels on FE is not a scalable one.
> 
> Please take a look at some of the patches that I shared privately.
> 

Ack

Best regards,
Krzysztof