Re: [PATCH v3 4/4] selftests/mm: Add new testcases for pkeys

From: Aruna Ramakrishna
Date: Tue May 07 2024 - 14:04:58 EST




> On May 7, 2024, at 9:56 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> On Tue, May 07 2024 at 14:05, Thomas Gleixner wrote:
>> On Thu, Apr 25 2024 at 18:05, Aruna Ramakrishna wrote:
>>> especially with pkey 0 disabled.
>>>
>>> Signed-off-by: Keith Lucas <keith.lucas@xxxxxxxxxx>
>>> Signed-off-by: Aruna Ramakrishna <aruna.ramakrishna@xxxxxxxxxx>
>
> Forgot to mention that this Signed-off-by chain is invalid.

Apologies for what is probably an obvious question.

Keith Lucas developed the testcases in the new file pkey_sighandler_tests.c.

I added them to tools/testing/selftests/mm (i.e. just the changes
to Makefile, protection_keys.c and some comments etc.).

So should I change this to:

Co-developed-by: Keith Lucas <keith.lucas@xxxxxxxxxx>
Signed-off-by: Keith Lucas <keith.lucas@xxxxxxxxxx>
Signed-off-by: Aruna Ramakrishna <aruna.ramakrishna@xxxxxxxxxx>

Thanks,
Aruna