Re: [PATCH v4 1/3] mm/rmap: remove duplicated exit code in pagewalk loop

From: Lance Yang
Date: Tue May 07 2024 - 10:54:03 EST


On Tue, May 7, 2024 at 10:51 PM Zi Yan <ziy@xxxxxxxxxx> wrote:
>
> On 1 May 2024, at 0:26, Lance Yang wrote:
>
> > Introduce the labels walk_done and walk_done_err as exit points to
> > eliminate duplicated exit code in the pagewalk loop.
> >
> > Signed-off-by: Lance Yang <ioworker0@xxxxxxxxx>
> > ---
> > mm/rmap.c | 40 +++++++++++++++-------------------------
> > 1 file changed, 15 insertions(+), 25 deletions(-)
>

Hey Zi,

> LGTM. Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>

Thanks for taking time to review!
Lance

> --
> Best Regards,
> Yan, Zi