Re: [PATCH v5 1/2] lib/test_bitops: Add benchmark test for fns()

From: Nathan Chancellor
Date: Tue May 07 2024 - 10:23:26 EST


On Mon, May 06, 2024 at 03:47:24PM -0700, Yury Norov wrote:
> On Mon, May 06, 2024 at 08:08:41PM +0200, Miguel Ojeda wrote:
> > On Mon, May 6, 2024 at 7:52 PM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
> > >
> > > No, unused can be used with local variables, used cannot.
> >
> > Yeah, sorry, I meant `used`, i.e. it is that one the one that
> > constraints the combination rather than `unused`.
> >
> > >From a quick look at the links in `compiler_attributes.h`, `unused`
> > can also be applied to types, while `used` cannot -- it is another
> > difference, but your sentence above already implies it anyway. :)
> >
> > Thanks for the correction!
>
> I have applied the patch in bitmap-for-next this weekend.
>
> https://github.com/norov/linux/commit/eb21fc0c96b48d1e779a0ab16f9165a3e0cd76ad
>
> Can you guys please take a look at it wrt the last comments? I think
> it's OK. But if not, I will resend it.

Yeah, I think it looks reasonable.

Cheers,
Nathan