Re: [PATCH v4 0/5] PCI: controller: Move to agnostic GPIO API

From: Andy Shevchenko
Date: Tue May 07 2024 - 09:13:33 EST


On Tue, May 07, 2024 at 12:03:50PM +0200, Linus Walleij wrote:
> On Mon, May 6, 2024 at 4:22 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> > In v4:
> > - added tag (Mani)
> > - fixed a polarity bug in iMX.6 driver (Linus)
>
> Looks good now. The series:
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thank you!

> Perhaps the use of _raw accessors could be avoided in 5/5 by some
> elaborart polarity quirk but I'm no perfectionist and it can be fixed later.

After your comment I was thinking the same, and came to the similar conclusion,
we might fix this later as in comparison to iMX.6 case this requires an
additional code to be added to gpiolib-of.c.

--
With Best Regards,
Andy Shevchenko