Re: [PATCH net-next v2 2/2] net: phy: marvell: add support for MV88E6250 family internal PHYs

[Andrew Lunn]

On Thu, May 02, 2024 at 01:13:01PM +0200, Matthias Schiffer wrote:
> The embedded PHYs of the 88E6250 family switches are very basic - they
> do not even have an Extended Address / Page register.
> 
> This adds support for the PHYs to the driver to set up PHY interrupts
> and retrieve error stats. To deal with PHYs without a page register,
> "simple" variants of all stat handling functions are introduced.
> 
> The code should work with all 88E6250 family switches (6250/6220/6071/
> 6070/6020). The PHY ID 0x01410db0 was read from a 88E6020, under the
> assumption that all switches of this family use the same ID. The spec
> only lists the prefix 0x01410c00 and leaves the last 10 bits as reserved,
> but that seems too unspecific to be useful, as it would cover several
> existing PHY IDs already supported by the driver; therefore, the ID read
> from the actual hardware is used.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@xxxxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew