Re: [PATCH v3 1/4] x86/pkeys: Signal handling function interface changes to accept PKRU as a parameter

From: Thomas Gleixner
Date: Tue May 07 2024 - 08:16:16 EST


On Thu, Apr 25 2024 at 18:05, Aruna Ramakrishna wrote:
>
> -extern bool copy_fpstate_to_sigframe(void __user *buf, void __user *fp, int size);
> +extern bool copy_fpstate_to_sigframe(void __user *buf, void __user *fp, int size,
> + u32 pkru);

No line break required. Line length is 100 characters. All over the place.

> @@ -229,6 +230,7 @@ handle_signal(struct ksignal *ksig, struct pt_regs *regs)
> {
> bool stepping, failed;
> struct fpu *fpu = &current->thread.fpu;
> + u32 pkru = read_pkru();

Please use reverse fir tree ordering of variables:

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#variable-declarations

Thanks,

tglx