Re: [PATCH v2 0/4] acpi/ghes, cper, cxl: Trace FW-First CXL Protocol Errors

From: Fabio M. De Francesco
Date: Tue May 07 2024 - 05:35:24 EST


On Tuesday, January 9, 2024 4:47:51 AM GMT+2 Smita Koralahalli wrote:
> This patchset adds trace event support for FW-First Protocol Errors.
>
> This series depends on:
> https://lore.kernel.org/linux-cxl/20231220-cxl-cper-v5-0-1bb8a4ca2c7a@intel.
> com
>
Hello Smita,

I'm working on a small series of enhancement and additions to kernel logs and
trace events in extlog_print() (ELOG). I'm interested to reuse from ELOG the
infrastructure which you made to trace the CXL Protocol Errors.

I'm aware that this series depends on an old one from Ira which has been
superseded by a different implementation and, furthermore, that this needs to
be reworked because the execution of this code may sleep while in atomic
context.

I'd like to ask if you plan to fix and rebase this series to a current cxl
branch. If so, I'll wait for the next version to integrate in ELOG.

Otherwise, if you are not anymore actively working on this series, please
notice that I'd be glad to help by making the necessary changes and by porting
your code to a current cxl branch (of course, retaining your authorship).

Thanks,

Fabio M. De Francesco
>
> Link to v1:
> https://lore.kernel.org/all/20240102150933.161009-1-Smita.KoralahalliChannab
> asappa@xxxxxxx
>
> Smita Koralahalli (4):
> acpi/ghes, cxl: Create a common CXL struct to handle different CXL
> CPER records
> efi/cper, cxl: Make definitions and structures global
> acpi/ghes, efi/cper: Recognize and process CXL Protocol Errors.
> acpi/ghes, cxl/pci: Trace FW-First CXL Protocol Errors
>
> drivers/acpi/apei/ghes.c | 22 ++++++++-
> drivers/cxl/core/pci.c | 29 ++++++++++++
> drivers/cxl/cxlpci.h | 3 ++
> drivers/cxl/pci.c | 13 ++++--
> drivers/firmware/efi/cper_cxl.c | 79 ++++++++++++++++++++++++++++-----
> drivers/firmware/efi/cper_cxl.h | 7 +--
> include/linux/cper.h | 4 ++
> include/linux/cxl-event.h | 31 ++++++++++++-
> 8 files changed, 166 insertions(+), 22 deletions(-)