Re: [PATCH 1/2] platform/chrome: cros_ec_framework_laptop: introduce driver

From: Lee Jones
Date: Tue May 07 2024 - 04:25:41 EST


On Sun, 05 May 2024, Thomas Weißschuh wrote:

> Framework Laptops are using embedded controller firmware based on the
> ChromeOS EC project.
> In addition to the standard upstream commands, some vendor-specific
> ones are implemented.
>
> Add a driver for those custom EC commands.
>
> At first, provide an empty driver that only takes care of scaffolding and
> device binding.
> Further patches will add functionality to the driver.
>
> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> ---
> MAINTAINERS | 5 ++
> drivers/mfd/cros_ec_dev.c | 13 ++++++

I do not see any build-time deps here.

Please split this change out.

> drivers/platform/chrome/Kconfig | 11 +++++
> drivers/platform/chrome/Makefile | 1 +
> drivers/platform/chrome/cros_ec_framework_laptop.c | 53 ++++++++++++++++++++++
> 5 files changed, 83 insertions(+)

--
Lee Jones [李琼斯]