Re: [PATCH] x86/fault: speed up uffd-unit-test by 10x: rate-limit "MCE: Killing" logs

From: David Hildenbrand
Date: Tue May 07 2024 - 04:13:48 EST


The patch subject is misleading. This should be "don't flood the system log". Nobody cares about the speed of a unittest ;)

On 07.05.24 04:29, John Hubbard wrote:
If a system experiences a lot of memory failures, then any associated
printk() output really needs to be rate-limited. I noticed this while
running selftests/mm/uffd-unit-tests, which logs 12,305 lines of output,
adding (on my system) an extra 97 seconds of runtime due to printk time.

Recently discussed:

https://lkml.kernel.org/r/a9e3120d-8b79-4435-b113-ceb20aa45ee2@xxxxxxxxxxxx

See the pros/cons of using ratelimiting, and what an alternative for uffd is that Axel is working on.

(CCing Peter and Axel)

--
Cheers,

David / dhildenb