Re: [GIT PULL] clk: samsung: drivers for v6.10

From: Krzysztof Kozlowski
Date: Tue May 07 2024 - 01:54:21 EST


On 07/05/2024 01:44, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2024-05-04 05:06:22)
>> The following changes since commit 4cece764965020c22cff7665b18a012006359095:
>>
>> Linux 6.9-rc1 (2024-03-24 14:10:05 -0700)
>>
>> are available in the Git repository at:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-clk-6.10
>
> I'm getting compile warnings. Is there a pending fix? Also, why is GS101

I don't see any of these warnings. Neither local (W=1), nor on my CI,
nor reported by LKP (which reported build successes for this branch).
How can I reproduce it?


> describing clk parents with strings instead of using clk_parent_data?

GS101 uses existing Samsuung clock framework, so that's how it is done
there. There is nothing odd here, comparing to other Samsung clocks.

>
> In file included from drivers/clk/samsung/clk-gs101.c:16:
> drivers/clk/samsung/clk-gs101.c:2616:7: error: ‘mout_hsi2_mmc_card_p’
> defined but not used [-Werror=unused-const-variable=]
> 2616 | PNAME(mout_hsi2_mmc_card_p) = { "fout_shared2_pll", "fout_shared3_pll",

I see indeed some unused variables and I will drop them but your
warnings are not reproducible.


Best regards,
Krzysztof