Re: [PATCH v2] HID: playstation: DS4: Fix calibration workaround for clone devices

[Jiri Kosina]

On Sun, 5 May 2024, Max Staudt wrote:

> The logic in dualshock4_get_calibration_data() used uninitialised data
> in case of a failed kzalloc() for the transfer buffer.

Good catch, this completely escaped my attention during review.

> 
> The solution is to group all business logic and all sanity checks
> together, and jump only to the latter in case of an error.
> While we're at it, factor out the axes' labelling, since it must happen
> either way for input_report_abs() to succeed later on.
> 
> Thanks to Dan Carpenter for the Smatch static checker warning.
> 
> Fixes: a48a7cd85f55 ("HID: playstation: DS4: Don't fail on calibration data request")
> Signed-off-by: Max Staudt <max@xxxxxxxxx>

Now queued on top of the for-6.10/playstation pile in hid.git.

Thanks,

-- 
Jiri Kosina
SUSE Labs