Re: [PATCH 2/4] dt-bindings: mfd: rk809: Add audio codec properties

[Krzysztof Kozlowski]

On 06/05/2024 18:14, Jonas Karlman wrote:
>>
>>> +
>>> +  codec:
>>> +    description: |
>>
>> Do not need '|' unless you need to preserve formatting.
>>
>>> +      The child node for the codec to hold additional properties. If no
>>> +      additional properties are required for the codec, this node can be
>>> +      omitted.
>>
>> That's useless description. Describe hardware, not syntax. This must say
>> what this node represents.
>>
>> Anyway drop it. You do not have any resources there, so put properties
>> in top level.
> 
> This just tries to follow the rockchip,rk817 binding, not fully sure
> about the reasoning behind this node in the the rk817 binding.
> 
> RK809/RK817 are very similar and their schema files could possible be
> merged.

That binding was a conversion from something older, so it might not be
in good shape. At least new binding should follow usual rules/style.


Best regards,
Krzysztof