Re: [PATCH v3 1/3] net: phy: bcm54811: New link mode for BroadR-Reach

[Florian Fainelli]

On 5/6/24 07:40, Kamil Horák - 2N wrote:
> Introduce new link modes necessary for the BroadR-Reach mode on
> bcm5481x PHY by Broadcom and new PHY tunable to choose between
> normal (IEEE) ethernet and BroadR-Reach modes of the PHY.

Missing Signed-off-by tag.

> ---
>   drivers/net/phy/phy-core.c   | 9 +++++----
>   include/uapi/linux/ethtool.h | 9 ++++++++-
>   net/ethtool/common.c         | 7 +++++++
>   net/ethtool/ioctl.c          | 1 +
>   4 files changed, 21 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/phy/phy-core.c b/drivers/net/phy/phy-core.c
> index 15f349e5995a..129e223d8985 100644
> --- a/drivers/net/phy/phy-core.c
> +++ b/drivers/net/phy/phy-core.c
> @@ -13,10 +13,9 @@
>    */
>   const char *phy_speed_to_str(int speed)
>   {
> -	BUILD_BUG_ON_MSG(__ETHTOOL_LINK_MODE_MASK_NBITS != 102,
> -		"Enum ethtool_link_mode_bit_indices and phylib are out of sync. "
> -		"If a speed or mode has been added please update phy_speed_to_str "
> -		"and the PHY settings array.\n");
> +	BUILD_BUG_ON_MSG(__ETHTOOL_LINK_MODE_MASK_NBITS != 103,
> +			 "Enum ethtool_link_mode_bit_indices and phylib are out of sync. If a speed or mode has been added please update phy_speed_to_str and the PHY settings array.\n"
> +			);

Unrelated change. I like Andrew's suggestion to key off advertising 
1BR10 to enable BroadR-Reach, but let's see what this discussion leads to.
--
Florian

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature