Re: [PATCH v2 3/3] Input: ektf2127 - add ektf2232 support

[Andy Shevchenko]

On Mon, May 6, 2024 at 7:21 PM Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:
> On Mon, 6 May 2024 15:05:52 +0300
> Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > To: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> > Date: Mon, 6 May 2024 15:05:52 +0300
> > On Mon, May 6, 2024 at 12:48 AM Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:

..

> > I'm wondering if you are using --histogram diff algo when preparing the patches.
>
> No, I am not using that, it seems to not make that chunk nicer.
> Yes, we want
>
> +       int status_shift;
>  };
> +
> +struct ektf2127_i2c_chip_data {
> +       int status_shift;
> +};
>
> But that is not shorter or simpler, just more readable.

And that's exactly what histogram is about. I suggest making it
default for the Linux kernel project (or globally in your
~/.gitconfig).


-- 
With Best Regards,
Andy Shevchenko