Re: [PATCH v5 linux-next] usb:typec:mux: remove indentation for common path

[R Sundar]

Hi Heikki,

On 06/05/24 14:29, Heikki Krogerus wrote:
> Hi Sundar,
>
> On Fri, Apr 26, 2024 at 10:17:05PM +0530, R Sundar wrote:
> > Nitpick, Mostly common path will not be indented.  so rewritten this
> > function to check device_node pointer is null and removed common path
> > indentation.
> >
> > Signed-off-by: R Sundar <prosunofficial@xxxxxxxxx>
>
> For the record, I'm still uncomfortable with the name - why not just
> spell out your whole name?

I understand your concern.  " R Sundar ",  is my whole name.

> > ---
> >
> > Fixed nitpicks in code according to comments received on other patch as
> > below:
>
> Sorry for missing this earlier, but it looks like this patch only
> modifies the nb7vpq904m driver, so I think you should specify that
> already in the subject.
> While at it, you could also specify the only function that is being
> modified in the commit message (this is just a suggestion):
>
>          usb: typec: nb7vpq904m: Remove uneeded indentation
>
>          In function nb7vpq904m_parse_data_lanes_mapping(), the "if
>          (ep)" condition is basically the entire function. Making the
>          code a bit more readable by inverting the condition so that
>          the function returns immedately if there is no "ep".
>
> thanks,

Thanks for the suggestion provided,  will modify the commit message and 
send the updated one.


Thanks,
Sundar