Re: [PATCH v3 1/8] arm64/sysreg: Add definitions for immediate versions of MSR ALLINT

[Mark Brown]

On Fri, May 03, 2024 at 05:00:49PM +0100, Mark Rutland wrote:
> On Mon, Apr 15, 2024 at 06:47:51AM +0000, Liao Chang wrote:

> +#define PSTATE_ALLINT                  pstate_field(1, 0)

> +#define set_pstate_allint(x)           asm volatile(SET_PSTATE_ALLINT(x))

Hrm, those helpers are not ideally discoverable, partly due to the
system register description for ALLINT not providing any references to
this being a general scheme (which is fixable there) and partly due to
the use of __emit_inst() with a numeric literal - we should probably add
a comment next to the __emit_inst() saying what instruction we are
emitting.

Attachment: signature.asc
Description: PGP signature