Re: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with both fixed and adjustable vout
From: Mark Brown
Date: Mon May 06 2024 - 10:58:43 EST
On Fri, May 03, 2024 at 03:35:36PM +0800, Alina Yu wrote:
> On Fri, May 03, 2024 at 10:41:04AM +0900, Mark Brown wrote:
> > That's a substantail reconfiguration of the regulator, it would be
> > better to have an explicit property for these non-standard fixed
> > voltages rather than trying to do this using constraints, or at the very
> > least have validation that the values being set are supported by the
> > hardware. The code should also be very clear about what is going on.
> May I add the 'richtek,use-fix-dvs' property back ?
It sounds like it might be better to add a property specifying the
specific fixed voltage rather than overloading the constraints for this
purpose.
Attachment:
signature.asc
Description: PGP signature