Re: [PATCH v2 0/3] drm/mediatek: Add support for OF graphs

[AngeloGioacchino Del Regno]

Il 06/05/24 15:17, Michael Walle ha scritto:
> Hi Angelo,
>
> On Mon May 6, 2024 at 1:22 PM CEST, AngeloGioacchino Del Regno wrote:
> > > The problem with this is that you need DDP_COMPONENT_DRM_OVL_ADAPTOR... which is
> > > a software thing and not HW, so that can't be described in devicetree.
> > >
> > > The only thing this series won't deal with is exactly that.
> >
> > Sorry, no, I got confused.
> >
> > The series *does* already deal with that, as the pipeline is built before the check
> > for OVL_ADAPTOR components, so that will get probed.
>
> Are you sure? Because who is actually adding the OVL_ADAPTOR to the
> path? It looks like your patch will walk the graph and add all the
> components according to their compatible string. And since the
> OVL_ADAPTOR is virtual and doesn't have a node..

I shouldn't look at code while having a flu.

	if (mtk_drm_find_mmsys_comp(private, DDP_COMPONENT_DRM_OVL_ADAPTOR)) {

..but yes nothing adds the mmsys_comp for OVL_ADAPTOR.

Needs to be addressed, will do that asap.