Re: [PATCH 0/2] platform/chrome: cros_ec_framework_laptop: new driver

From: Limonciello, Mario
Date: Mon May 06 2024 - 09:09:22 EST




On 5/6/2024 1:09 AM, Thomas Weißschuh wrote:
On 2024-05-05 22:56:33+0000, Thomas Weißschuh wrote:
Framework Laptops are using embedded controller firmware based on the
ChromeOS EC project.
In addition to the standard upstream commands some vendor-specific
commands are implemented.

Add a driver that implements battery charge thresholds using these
custom commands.

It turns out that standard ChromesOS EC defines EC_CMD_CHARGE_CONTROL.
The kernel headers however only define v1 of the protocol, which is very
limited.

But in the upstream firmware repo there is a v3 which is much better.

The Framework laptop only implements v2 which is also fine.
Given that v3 was only introduced late last year, it seems better to
stick to v2 anyways for now.

So please disregard Patch 2, I'll see on how to use this via a normal
cros_ec driver.

There are some other Framework-only features that will use Patch 1,
so feedback for that would still be good.

What other kinds of features do you have in mind?

Considering your above finding I think it's better to put patch 1 into the series of "other framework only features" that will use it so it's clearer if it's the best way or not.


Patch 1 adds the general scaffolding and device binding.
Patch 2 implements the battery charge thresholds.

This series is based on
https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
---
Thomas Weißschuh (2):
platform/chrome: cros_ec_framework_laptop: introduce driver
platform/chrome: cros_ec_framework_laptop: implement battery charge thresholds

MAINTAINERS | 5 +
drivers/mfd/cros_ec_dev.c | 13 ++
drivers/platform/chrome/Kconfig | 11 ++
drivers/platform/chrome/Makefile | 1 +
drivers/platform/chrome/cros_ec_framework_laptop.c | 173 +++++++++++++++++++++
5 files changed, 203 insertions(+)
---
base-commit: 2fbe479c0024e1c6b992184a799055e19932aa48
change-id: 20240505-cros_ec-framework-10e627c46a0a

Best regards,
--
Thomas Weißschuh <linux@xxxxxxxxxxxxxx>