Re: [PATCH 14/14] alpha: drop pre-EV56 support

From: Arnd Bergmann
Date: Mon May 06 2024 - 06:07:08 EST


On Sat, May 4, 2024, at 17:00, Richard Henderson wrote:
> On 5/3/24 01:11, Arnd Bergmann wrote:
>>
>> -/* Flush just one page in the current TLB set. We need to be very
>> - careful about the icache here, there is no way to invalidate a
>> - specific icache page. */
>> -
>> -__EXTERN_INLINE void
>> -ev4_flush_tlb_current_page(struct mm_struct * mm,
>> - struct vm_area_struct *vma,
>> - unsigned long addr)
>> -{
>> - int tbi_flag = 2;
>> - if (vma->vm_flags & VM_EXEC) {
>> - __load_new_mm_context(mm);
>> - tbi_flag = 3;
>> - }
>> - tbi(tbi_flag, addr);
>> -}
>> -
>> __EXTERN_INLINE void
>> ev5_flush_tlb_current_page(struct mm_struct * mm,
>> struct vm_area_struct *vma,
>
> The comment being removed applied to both functions and still applies to
> ev5_flush_tlb_current_page. (Thus __load_new_mm_context instead of a tbi.)

Fixed now, thanks for taking a look!

Arnd