Re: [PATCH] i3c: dw: Disable IBI IRQ depends on hot-join and SIR enabling
From: Jeremy Kerr
Date: Mon May 06 2024 - 02:58:17 EST
Hi Dylan,
> > The initial state would be to have all SIRs masked.
> >
>
> Yes, indeed. The "global" variable is also true because "reg ==
> 0xffffffff" is true.
> Therefore, the INTR_IBI_THLD_STAT bit will be set in the following
> code.
That's mainly my point - none of this code is ever run unless the
->enable_ibi or ->disable_ibi controller callback is invoked.
So we'll end up with the HJ interrupt only being enabled if some i3c
device driver enables IBIs, which is a bit of a weird side-effect.
It probably makes more sense when the rest of the HJ code is added, but
not so much as a standalone patch.
Cheers,
Jeremy