Re: [RFT PATCH v2 46/48] drm/panel: sony-acx565akm: Don't double-check enabled state in disable

[Linus Walleij]

On Fri, May 3, 2024 at 11:38 PM Douglas Anderson <dianders@chromiumorg> wrote:

> As talked about in commit d2aacaf07395 ("drm/panel: Check for already
> prepared/enabled in drm_panel"), we want to remove needless code from
> panel drivers that was storing and double-checking the
> prepared/enabled state. Even if someone was relying on the
> double-check before, that double-check is now in the core and not
> needed in individual drivers.
>
> The acx565akm seems to do some unique stuff with the "enabled"
> state. Specifically:
> 1. It seems to detect the enabled state based on how the bootloader
>    left the panel.
> 2. It uses the enabled state to prevent certain sysfs files from
>    accessing a disabled panel.
>
> We'll leave the "enabled" state tracking for this. However, we can at
> least get rid of the double-check when trying to disable.
>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij