Re: [PATCH v10 09/27] KVM: x86: Rename kvm_{g,s}et_msr()* to menifest emulation operations

From: Yang, Weijiang
Date: Mon May 06 2024 - 01:59:00 EST


On 5/2/2024 2:54 AM, Sean Christopherson wrote:
s/menifest/manifest, though I find the shortlog confusing irrespective of the
typo. I think this would be more grammatically correct:

KVM: x86: Rename kvm_{g,s}et_msr()* to manifest their emulation operations

but I still find that unnecessarily "fancy". What about this instead?

KVM: x86: Rename kvm_{g,s}et_msr()* to show that they emulate guest accesses

It's not perfect, e.g. it might be read as saying they emulate guest RDMSR and
WRMSR, but for a shortlog I think that's fine.

Sorry for the delayed reply!
It looks good to me, will change it in next version, thanks!